test: add pytest-randomly to cuda_pathfinder#1269
Merged
cpcloud merged 2 commits intoNVIDIA:mainfrom Feb 17, 2026
Merged
Conversation
Contributor
Author
|
/ok to test |
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This comment has been minimized.
This comment has been minimized.
leofang
added
enhancement
cpcloud
force-pushed
the
pytest-randomly-cuda-pathfinder
branch
2 times, most recently
from
4ca9146 to
28753fc
Compare
Contributor
Author
|
/ok to test |
rwgk
approved these changes
Jan 30, 2026
cpcloud
force-pushed
the
pytest-randomly-cuda-pathfinder
branch
from
28753fc to
4d0ee23
Compare
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
pytest-randomly-cuda-pathfinder
branch
from
4d0ee23 to
ecf4186
Compare
Collaborator
|
Is this going to randomize the order of our unit tests for ever pytest run? I thought we were going to have a specific CI job that randomized the order to avoid inflicting flakiness on people while we work out bugs. |
cpcloud
force-pushed
the
pytest-randomly-cuda-pathfinder
branch
from
ecf4186 to
bd7c8c6
Compare
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
cpcloud
force-pushed
the
pytest-randomly-cuda-pathfinder
branch
from
bd7c8c6 to
c7b0d67
Compare
Contributor
Author
|
/ok to test |
Adding pytest-randomly for cuda_pathfinder currently affects bindings/core in shared CI jobs and exposes unrelated order-dependent failures. Disable collection reordering for bindings/core invocations to keep those suites stable while pathfinder adopts randomization. Co-authored-by: Cursor <[email protected]>
cpcloud
force-pushed
the
pytest-randomly-cuda-pathfinder
branch
from
30ea0a7 to
0f6f7b0
Compare
Contributor
Author
|
/ok to test |
Contributor
Author
|
Ended up just disabling randomly for bindings core for now, since this PR is only about pathfinder. |
|
Contributor
Author
|
@rparolin Missed your comment. Happy to revert, but it might be easier to just see whether it's a burden. If it is, let's revert then, is my thinking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pytest-randomly to cuda_pathfinder. Tests are randomized by default.
pytest-randomlydocs